-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Bramburn/refactor/cline provider.ts/002 #2602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bramburn/refactor/cline provider.ts/002 #2602
Conversation
- 【What】Move the logic for generating webview HTML content from ClineProvider to a new WebviewHTMLManager class. - 【Why】This improves code organization and maintainability by separating concerns related to webview HTML generation. - 【Why】This allows for easier testing and modification of the HTML generation logic without affecting the ClineProvider class.
…mburn/refactor/clineProvider.ts/002
|
|
are you running on MAC? i'll boot up my mac and test it later.
Regards,
B.Ramburn BSc (Hons) LLM MCIArb
Snr. Quantity Surveyor & Director at Icelabz
…On Mon, 14 Apr 2025 at 19:22, Matt Rubens ***@***.***> wrote:
I'm still having the same problem
—
Reply to this email directly, view it on GitHub
<#2602 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUTT3K46GXEFLB6FFJ4JMT2ZP4HPAVCNFSM6AAAAAB3DIDG7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBSGU2TSOJTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*mrubens* left a comment (RooCodeInc/Roo-Code#2602)
<#2602 (comment)>
I'm still having the same problem
—
Reply to this email directly, view it on GitHub
<#2602 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACUTT3K46GXEFLB6FFJ4JMT2ZP4HPAVCNFSM6AAAAAB3DIDG7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBSGU2TSOJTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hey @bramburn, |

Context
Continuing from #2494 I just rebuilt it and it seems to work. I can see if there is another error
Implementation
Screenshots
How to Test
Get in Touch
Important
Refactor HTML content generation in
ClineProvider.tsby moving it toWebviewHTMLManager.tsfor better code organization.ClineProvider.tstoWebviewHTMLManager.ts.getHMRHtmlContentandgetHtmlContentfromClineProvider.ts.WebviewHTMLManagerclass withgetHMRHtmlContentandgetHtmlContentmethods.getNonceandgetUriimports fromClineProvider.ts.WebviewHTMLManagerimport toClineProvider.ts.ClineProvidernow usesWebviewHTMLManagerfor HTML content generation inresolveWebviewView().This description was created by
for c4807b9. It will automatically update as commits are pushed.